Skip to content

Update hash for Kickstarter-Prelude and Kickstarter-ReactiveExtensions #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 30, 2018
Merged

Update hash for Kickstarter-Prelude and Kickstarter-ReactiveExtensions #211

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7445968
Update maintainer contact details, add Kickstarter iOS OSS repo
justinswart Jul 9, 2018
9917fab
Run against 4.1, improve naming
justinswart Jul 10, 2018
4ad8c51
Update path name
justinswart Jul 10, 2018
c72b7f3
Remove 3.0 hashes
justinswart Jul 10, 2018
f288417
Remove tvOS schemes, remove app for now.
justinswart Jul 17, 2018
106bba9
Merge branch 'master' into add-kickstarter-oss
justinswart Jul 17, 2018
931364e
Merge branch 'master' into add-kickstarter-oss
justinswart Oct 12, 2018
3dcc22f
Remove tvOS targets
justinswart Oct 12, 2018
101870f
Update Prelude to 4.2, fix submodule address
justinswart Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,12 @@
"url": "https://github.com/kickstarter/Kickstarter-Prelude",
"path": "Kickstarter-Prelude",
"branch": "master",
"maintainer": "stephen@stephencelis.com",
"maintainer": "justins@kickstarter.com",
"compatibility": [
{
"version": "4.0",
"commit": "7b4eff0bae4f1abaf8ccc8370153f0945e0752ae"
},
{
"version": "3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have a 4.0 hashes, we can drop the 3.0 hashes. Would you mind updating this to remove the 3.0 configurations for Kickstarter-Prelude and Kickstarter-ReactiveExtensions? (That trailing comma after each 4.0 configuration also causes problems if it's not removed.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

"commit": "9b2cc23ce8acf29b4b666a80a665c67cba800aac"
Expand Down Expand Up @@ -874,8 +878,12 @@
"url": "https://github.com/kickstarter/Kickstarter-ReactiveExtensions",
"path": "Kickstarter-ReactiveExtensions",
"branch": "master",
"maintainer": "stephen@stephencelis.com",
"maintainer": "justins@kickstarter.com",
"compatibility": [
{
"version": "4.0",
"commit": "6b7887e7b38ebd81e2d04a936e64998b0f634e98"
},
{
"version": "3.0",
"commit": "732eab9da730699f264dceb4f423586754191d67"
Expand Down Expand Up @@ -915,6 +923,31 @@
}
]
},
{
"repository": "Git",
"url": "https://github.com/kickstarter/ios-oss",
"path": "Kickstarter",
"branch": "master",
"maintainer": "[email protected]",
"compatibility": [
{
"version": "4.1",
"commit": "bec03d1095131d820dff0e845981e7ea296caeb3"
}
],
"platforms": [
"Darwin"
],
"actions": [
{
"action": "BuildXcodeProjectScheme",
"project": "Kickstarter.xcodeproj",
"scheme": "Kickstarter-iOS",
"destination": "generic/platform=iOS",
"configuration": "Release"
}
]
},
{
"repository": "Git",
"url": "https://github.com/onevcat/Kingfisher.git",
Expand Down