Update hash for Kickstarter-Prelude and Kickstarter-ReactiveExtensions #211

justinswart · 2018-07-10T01:49:05Z

Updated maintainer details
Added Kickstarter iOS app

justinswart · 2018-07-10T01:49:35Z

@swift-ci test

justinswart · 2018-07-10T01:57:39Z

@swift-ci test

justinswart · 2018-07-10T01:58:28Z

@clackary apologies for taking some time to get around to this. Let me know if I've done it correctly! 👍

clackary · 2018-07-10T19:48:16Z

@justinswart No worries! I should be able to get testing for it started in the next day or two. Our PR testing is down at the moment, and I'm working to get it back up.

clackary · 2018-07-10T19:56:03Z

projects.json

+      {
+        "version": "4.0",
+        "commit": "7b4eff0bae4f1abaf8ccc8370153f0945e0752ae"
+      },
      {
        "version": "3.0",


Now that we have a 4.0 hashes, we can drop the 3.0 hashes. Would you mind updating this to remove the 3.0 configurations for Kickstarter-Prelude and Kickstarter-ReactiveExtensions? (That trailing comma after each 4.0 configuration also causes problems if it's not removed.)

clackary · 2018-07-12T03:50:46Z

@swift-ci test

rudkx · 2018-07-12T16:24:23Z

@justinswart It looks like this is hitting an issue because of a missing framework:

ld: framework not found Runes

justinswart · 2018-07-12T16:40:25Z

Apologies! Give me a bit of time to look into this, I had some issues running the pre-commit python script locally but have it running now so can try to debug.

rudkx · 2018-07-12T16:43:49Z

@justinswart No worries!

justinswart · 2018-07-12T18:41:41Z

🤔 I forgot that we need to run make bootstrap for our project to sync its dependencies and to also do some juggling with our app secrets file. Is it possible to run a custom command like this through the projects.json configuration file?

clackary · 2018-07-12T20:55:00Z

@justinswart It is not possible to run commands through projects.json. Might be possible to do it in a pre/post-build step in the Xcode scheme?

# Conflicts: # projects.json

clackary · 2018-07-17T19:22:47Z

@swift-ci test

justinswart · 2018-07-17T19:24:02Z

@clackary just removing the stuff that isn't working for now until I can make some time to look into it a bit more

clackary · 2018-07-18T18:44:10Z

@swift-ci test

justinswart · 2018-08-27T01:28:24Z

I'd like to take a look at this again - is there an environment variable on your CI that I could check for to run make bootstrap? We don't run it on every build in Xcode so I would want to make it conditional, something like:

if [ -z "${SWIFTCI:-}" ]; then
  make bootstrap
fi

clackary · 2018-08-30T18:29:05Z

@justinswart I'm not sure about an environment variable like that. Hey @shahmishal, any idea if something like this exists?

shahmishal · 2018-09-12T01:06:29Z

I created a PR (#245) to add an environment variable to the source compatibility suite. Hopefully by adding the environment variable to the project.py it will build the same way as CI.

shahmishal · 2018-09-12T05:12:37Z

@justinswart Can you try using SWIFT_SOURCE_COMPAT_SUITE environment variable?

justinswart · 2018-09-12T15:37:23Z

Thanks @shahmishal I will try that!

slavapestov · 2018-10-11T03:42:05Z

It would be great to merge this soon - we want to remove Swift 3 support.

justinswart · 2018-10-11T16:45:27Z

@slavapestov apologies for the delay, @ifbarrera and I have some time set up to hand this over and get it wrapped up soonest!

# Conflicts: # projects.json

ifbarrera · 2018-10-12T19:02:10Z

@swift-ci Please test source compatibility

clackary · 2018-10-12T19:05:09Z

@swift-ci test

shahmishal · 2018-10-12T19:09:18Z

@ifbarrera Unfortunately, only users with commit access can trigger @swift-ci due to security reasons.

justinswart · 2018-10-12T20:17:11Z

We'd like to use this PR just to update the hashes for ReactiveExtensions and Prelude to 4.0 and then create a separate PR to add the app. We've done some work on that on our end but would like to spend a little more time on it and not hold this up.

Any ideas why this is failing with 14:42:17 ld: warning: Could not find auto-linked library 'swiftMetal'?

shahmishal · 2018-10-12T20:24:40Z

14:42:17 ld: warning: Could not find auto-linked library 'swiftMetal'
14:42:17 Undefined symbols for architecture x86_64:
14:42:17   "__swift_FORCE_LOAD_$_swiftMetal", referenced from:
14:42:17       __swift_FORCE_LOAD_$_swiftMetal_$_Vision in Vision.o
14:42:17      (maybe you meant: __swift_FORCE_LOAD_$_swiftMetal_$_Vision)
14:42:17 ld: symbol(s) not found for architecture x86_64
14:42:17

We have seen this issue on the master branch before however, it should have been resolved by now.

Going to re-trigger the build

@swift-ci test

shahmishal · 2018-10-12T20:25:40Z

@swift-ci test

shahmishal · 2018-10-12T22:46:20Z

New failure

$ git -C /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/Kickstarter-Prelude submodule update --init --recursive
Submodule 'Frameworks/Runes' (git://github.com/thoughtbot/Runes.git) registered for path 'Frameworks/Runes'
Cloning into '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/Kickstarter-Prelude/Frameworks/Runes'...
fatal: unable to connect to github.com:
github.com[0: 192.30.255.112]: errno=Connection refused
github.com[1: 192.30.255.113]: errno=Connection refused

fatal: clone of 'git://github.com/thoughtbot/Runes.git' into submodule path '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/Kickstarter-Prelude/Frameworks/Runes' failed
Failed to clone 'Frameworks/Runes'. Retry scheduled
Cloning into '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/Kickstarter-Prelude/Frameworks/Runes'...
fatal: unable to connect to github.com:
github.com[0: 192.30.255.113]: errno=Connection refused
github.com[1: 192.30.255.112]: errno=Connection refused

fatal: clone of 'git://github.com/thoughtbot/Runes.git' into submodule path '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-test-macOS/project_cache/Kickstarter-Prelude/Frameworks/Runes' failed
Failed to clone 'Frameworks/Runes' a second time, aborting

justinswart · 2018-10-12T23:39:59Z

I thought we fixed the Runes issue 🤔 ok we'll check this out again next week!

justinswart · 2018-10-16T19:52:15Z

@shahmishal In the log you posted it seems to say github.com[0: 192.30.255.112]: errno=Connection refused

Is that not a potential issue from the CI side?

slavapestov · 2018-10-16T20:16:35Z

@swift-ci test

clackary · 2018-10-29T17:12:13Z

@swift-ci test

shahmishal · 2018-10-29T17:27:18Z

@justinswart We need to look into why git submodule update --init --recursive is having issues accessing GitHub.com from the Jenkins server.

shahmishal · 2018-10-29T17:38:59Z

@justinswart Found the issue with the submodule

.gitmodules

[submodule "Frameworks/Runes"]
        path = Frameworks/Runes
        url = git://github.com/thoughtbot/Runes.git

Is it possible to switch this to be url = https://github.com/thoughtbot/Runes.git?

Correction: it should be url = https://github.com/thoughtbot/Runes not url = https://github.com/thoughtbot/Runes.git

justinswart · 2018-10-29T17:45:02Z

@shahmishal sure - I can make that change 👍

justinswart · 2018-10-29T23:04:05Z

I've opened a PR on our repo for this change, also updated to Swift 4.2 (I'll update the hashes).

Are you sure about the URL, I think the one your originally posted was correct, tested in terminal:

$ git clone https://github.com/thoughtbot/Runes.git
Cloning into 'Runes'...
remote: Enumerating objects: 898, done.
remote: Total 898 (delta 0), reused 0 (delta 0), pack-reused 898
Receiving objects: 100% (898/898), 231.89 KiB | 827.00 KiB/s, done.
Resolving deltas: 100% (437/437), done.
$ git clone https://github.com/thoughtbot/Runes
fatal: destination path 'Runes' already exists and is not an empty directory.

shahmishal · 2018-10-29T23:10:13Z

If it works with .git, I am fine with that too. However, I looked at .gitmodules submodule from Kickstarter-ReactiveExtensions (https://github.com/kickstarter/Kickstarter-ReactiveExtensions/blob/master/.gitmodules)

clackary · 2018-10-30T17:17:18Z

@swift-ci test

clackary · 2018-10-30T17:18:44Z

@swift-ci test

justinswart · 2018-10-30T17:20:42Z

If this fixes the PR then it's likely that the git:// vs https:// was the problem when we were adding the main app repo too.

If so then I will create a separate PR to add the app to the compatibility suite.

clackary · 2018-10-30T17:26:05Z

Testing should start shortly, waiting for an available executor in CI.

shahmishal · 2018-10-30T17:26:40Z

@justinswart thanks!

clackary · 2018-10-30T17:29:29Z

@swift-ci test

shahmishal · 2018-10-30T18:51:33Z

PASS: Kickstarter-Prelude, 4.2, 8988b0, Prelude-iOS, generic/platform=iOS
PASS: Kickstarter-Prelude, 4.2, 8988b0, Prelude-UIKit-iOS, generic/platform=iOS
PASS: Kickstarter-ReactiveExtensions, 4.0, 6b7887, ReactiveExtensions-iOS, generic/platform=iOS
PASS: Kickstarter-ReactiveExtensions, 4.0, 6b7887, ReactiveExtensions-TestHelpers-iOS, generic/platform=iOS

justinswart · 2018-10-30T19:20:00Z

Nice! apologies once again for how long this took, we've just had a lot going on!

I'll create the app PR soon.

shahmishal · 2018-10-30T19:38:07Z

@justinswart @clackary Thanks!

justinswart added 2 commits July 9, 2018 15:59

Update maintainer contact details, add Kickstarter iOS OSS repo

7445968

Run against 4.1, improve naming

9917fab

Update path name

4ad8c51

clackary requested changes Jul 10, 2018

View reviewed changes

Remove 3.0 hashes

c72b7f3

clackary approved these changes Jul 10, 2018

View reviewed changes

rudkx mentioned this pull request Jul 13, 2018

Temporarily remove Kickstarter-ReactiveExtensions and RxDataSources. #219

Merged

justinswart added 2 commits July 17, 2018 14:59

Remove tvOS schemes, remove app for now.

f288417

Merge branch 'master' into add-kickstarter-oss

106bba9

# Conflicts: # projects.json

clackary changed the title ~~Add Kickstarter iOS app~~ Update hash for Kickstarter-Prelude and Kickstarter-ReactiveExtensions Jul 18, 2018

justinswart added 2 commits October 12, 2018 11:11

Merge branch 'master' into add-kickstarter-oss

931364e

# Conflicts: # projects.json

Remove tvOS targets

3dcc22f

justinswart mentioned this pull request Oct 29, 2018

Move Runes to HTTPS, update tvOS target to Swift 4.2 kickstarter/Kickstarter-Prelude#90

Merged

Update Prelude to 4.2, fix submodule address

101870f

shahmishal merged commit 965cfe4 into swiftlang:master Oct 30, 2018

Update hash for Kickstarter-Prelude and Kickstarter-ReactiveExtensions #211

Update hash for Kickstarter-Prelude and Kickstarter-ReactiveExtensions #211

Uh oh!

Conversation

justinswart commented Jul 10, 2018

Uh oh!

justinswart commented Jul 10, 2018

Uh oh!

justinswart commented Jul 10, 2018

Uh oh!

justinswart commented Jul 10, 2018

Uh oh!

clackary commented Jul 10, 2018

Uh oh!

clackary Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

justinswart Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

clackary commented Jul 12, 2018

Uh oh!

rudkx commented Jul 12, 2018

Uh oh!

justinswart commented Jul 12, 2018

Uh oh!

rudkx commented Jul 12, 2018

Uh oh!

justinswart commented Jul 12, 2018

Uh oh!

clackary commented Jul 12, 2018

Uh oh!

clackary commented Jul 17, 2018

Uh oh!

justinswart commented Jul 17, 2018

Uh oh!

clackary commented Jul 18, 2018

Uh oh!

justinswart commented Aug 27, 2018

Uh oh!

clackary commented Aug 30, 2018

Uh oh!

shahmishal commented Sep 12, 2018

Uh oh!

shahmishal commented Sep 12, 2018

Uh oh!

justinswart commented Sep 12, 2018

Uh oh!

slavapestov commented Oct 11, 2018

Uh oh!

justinswart commented Oct 11, 2018

Uh oh!

ifbarrera commented Oct 12, 2018

Uh oh!

clackary commented Oct 12, 2018

Uh oh!

shahmishal commented Oct 12, 2018

Uh oh!

justinswart commented Oct 12, 2018

Uh oh!

shahmishal commented Oct 12, 2018

Uh oh!

shahmishal commented Oct 12, 2018

Uh oh!

shahmishal commented Oct 12, 2018

Uh oh!

justinswart commented Oct 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinswart commented Oct 16, 2018

Uh oh!

slavapestov commented Oct 16, 2018

Uh oh!

clackary commented Oct 29, 2018

Uh oh!

shahmishal commented Oct 29, 2018

Uh oh!

shahmishal commented Oct 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinswart commented Oct 12, 2018 •

edited

Loading

shahmishal commented Oct 29, 2018 •

edited

Loading