Temporarily remove Kickstarter-ReactiveExtensions and RxDataSources. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently have Swift 4.x hashes for these. Kickstarter is being worked on in #211, but that is not ready yet. I tried to update RxDataSources myself, but ran into issues because updating the hash means also updating other parts of the build, and I was unable to figure out how to do that. After I merge swiftlang/swift#17691, I will revert this commit and add XFAILs for these 3.x configurations, including links to JIRAs so that we don't lose track of the fact that we still need to update these for 4.x.
|
@swift-ci Please test |
|
@justinswart, mind if I do this for now while you're continuing to work on getting the project set up with new hashes? |
|
Sure, thanks @rudkx, I'll try to spend some time on that soon. |
rudkx
deleted the
remove-Kickstarter-ReactiveExtensions-and-RxDataSources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently have Swift 4.x hashes for these.
Kickstarter is being worked on in
#211, but that
is not ready yet.
I tried to update RxDataSources myself, but ran into issues because
updating the hash means also updating other parts of the build, and I
was unable to figure out how to do that.
After I merge swiftlang/swift#17691, I will revert
this commit and add XFAILs for these 3.x configurations, including
links to JIRAs so that we don't lose track of the fact that we still
need to update these for 4.x.