Skip to content

project_precommit_check: Add 5.3 as a supported configuration #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2021
Merged

project_precommit_check: Add 5.3 as a supported configuration #508

merged 2 commits into from
Apr 15, 2021

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Apr 6, 2021

Allow the use of the 5.3 compiler in precommit checks.

@lorentey lorentey requested a review from clackary April 6, 2021 18:40
@lorentey lorentey requested a review from shahmishal as a code owner April 6, 2021 18:40
@lorentey
Copy link
Member Author

lorentey commented Apr 6, 2021

@swift-ci test

@lorentey lorentey mentioned this pull request Apr 6, 2021
Merged
10 tasks
shahmishal
shahmishal reviewed Apr 6, 2021
View reviewed changes
@lorentey
Copy link
Member Author

lorentey commented Apr 6, 2021

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Apr 7, 2021 

Failures:
  FAIL: siesta, 5.1, cb9c1b, Swift Package
  FAIL: Nimble, 5.1, eea584, Swift Package

Looks like a Nimble dependency has suffered a source-breaking update.

error: the library 'Nimble' requires macos 10.10, but depends on the product 'CwlPreconditionTesting' which requires macos 10.11; consider changing the library 'Nimble' to require macos 10.11 or later, or the product 'CwlPreconditionTesting' to require macos 10.10 or earlier.
error: the library 'Nimble' requires macos 10.10, but depends on the product 'CwlPosixPreconditionTesting' which requires macos 10.11; consider changing the library 'Nimble' to require macos 10.11 or later, or the product 'CwlPosixPreconditionTesting' to require macos 10.10 or earlier.

@lorentey
Copy link
Member Author

@swift-ci test

1 similar comment
@clackary
Copy link
Contributor

@swift-ci test

@lorentey lorentey merged commit 0e25af0 into swiftlang:main Apr 15, 2021
@lorentey lorentey deleted the register-5.3 branch April 15, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal left review comments

@clackary clackary clackary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentey @clackary @shahmishal