Skip to content

Add swift-collections and swift-collections-benchmark #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Apr 6, 2021

Pull Request Description

Add the recently announced Swift Collections and Swift Collections Benchmark packages to the source compatibility suite.

Note: This requires #508 for the precommit check to pass.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests (we build against 5.3)
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

$ swiftc --version
Apple Swift version 5.3.2 (swiftlang-1200.0.45 clang-1200.0.32.28)
Target: x86_64-apple-darwin20.4.0
$ /project_precommit_check swift-collections --swiftc /usr/bin/swiftc --earliest-compatible-swift-version 5.3
** CHECK **
--- Validating swift-collections Swift version 5.3 compatibility ---
--- Project configured to be compatible with Swift 5.3 ---
--- Checking swift-collections platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Checking installed Swift version ---
$ /usr/bin/swiftc --version
--- Version check succeeded ---
--- Executing build actions ---
$ /Users/klorentey/Swift/swift-source-compat-suite/runner.py --swift-branch swift-5.3-branch --swiftc /usr/bin/swiftc --projects /Users/klorentey/Swift/swift-source-compat-suite/projects.json --include-repos 'path == "swift-collections"' --include-versions 'version == "5.3"' --include-actions 'action.startswith("Build")'
PASS: swift-collections, 5.3, bd9240, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
$ ./project_precommit_check swift-collections-benchmark --swiftc /usr/bin/swiftc --earliest-compatible-swift-version 5.3
** CHECK **
--- Validating swift-collections-benchmark Swift version 5.3 compatibility ---
--- Project configured to be compatible with Swift 5.3 ---
--- Checking swift-collections-benchmark platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Checking installed Swift version ---
$ /usr/bin/swiftc --version
--- Version check succeeded ---
--- Executing build actions ---
$ /Users/klorentey/Swift/swift-source-compat-suite/runner.py --swift-branch swift-5.3-branch --swiftc /usr/bin/swiftc --projects /Users/klorentey/Swift/swift-source-compat-suite/projects.json --include-repos 'path == "swift-collections-benchmark"' --include-versions 'version == "5.3"' --include-actions 'action.startswith("Build")'
PASS: swift-collections-benchmark, 5.3, 492976, Swift Package
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- swift-collections-benchmark checked successfully against Swift 5.3 ---

@lorentey
Copy link
Member Author

lorentey commented Apr 6, 2021

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Apr 7, 2021

The logs seem to indicate swift-collections failed to build, but there are no detailed build logs. I’m assuming this is yet another case of apple/swift-collections#7.

Holding until we figure out a solution for that.

@lorentey lorentey force-pushed the add-collections-package branch from 273a970 to e581c6d Compare April 12, 2021 18:24
@lorentey
Copy link
Member Author

Commit hash updated to swift-collections 0.0.2, which includes the workaround for the compiler issue.

@swift-ci test

@lorentey
Copy link
Member Author

18:55:00 PASS: swift-collections, 5.3, 2d719d, Swift Package
18:56:31 PASS: swift-collections-benchmark, 5.3, 492976, Swift Package
...
18:56:31 UPasses:
18:56:31   UPASS: https://bugs.swift.org/browse/SR-14477, BeaconKit, 5.1, c40f34, Swift Package
18:56:31   UPASS: https://bugs.swift.org/browse/SR-14477, BeaconKit, 4.0, 6e6b0f, Swift Package

@clackary
Copy link
Contributor

@swift-ci test

@lorentey lorentey merged commit 150f37d into swiftlang:main Apr 15, 2021
@lorentey lorentey deleted the add-collections-package branch April 15, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants