Skip to content

Drop Kingfisher 4.0 configuration #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

clackary
Copy link
Contributor

Pull Request Description

Drops Kingfisher configuration for 4.0, as the commit reference in projects.json no longer exists on the branch.

@clackary clackary requested a review from shahmishal as a code owner April 21, 2021 17:23
@clackary
Copy link
Contributor Author

@onevcat Hi there, just wanted to let you know we've removed the 4.0 configuration for Kingfisher because a5d1214220b8ddf29acf7c08c8bb42993ed56c54 doesn't appear to exist on Kingfisher:master branch.

Feel free to add this configuration again with a different commit!

For reference: https://ci.swift.org/view/Source%20Compatibility/job/swift-main-source-compat-suite/5844/artifact/swift-source-compat-suite/None_Kingfisher_4.0_BuildXcodeWorkspaceScheme_Kingfisher_generic-platform-iOS.log

@clackary
Copy link
Contributor Author

@swift-ci test

@clackary
Copy link
Contributor Author

Oh bummer, it looks like the 5.1 configuration is failing in the same way.

$ git clone https://github.com/onevcat/Kingfisher.git /Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/Kingfisher
Cloning into '/Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/Kingfisher'...
$ git -C /Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/Kingfisher checkout -f 23ef6c73ee3bc12ee3940136aea54bd44a02e93e
fatal: reference is not a tree: 23ef6c73ee3bc12ee3940136aea54bd44a02e93e

I'll try a different commit here.

@clackary
Copy link
Contributor Author

@swift-ci test

@onevcat
Copy link
Contributor

onevcat commented Apr 22, 2021

I did a git reflog recently and I will update the config file soon!

@onevcat
Copy link
Contributor

onevcat commented Apr 22, 2021

Oh! Just saw that you've already gotten a new commit hash for Swift 5.1. That should be fine now since Kingfisher will not support Swift 4.x in the latest versions.

There is no change from me. LGTM!

@shahmishal
Copy link
Member

03:59:04.005 FAIL: Kingfisher, 5.1, 44450a, Kingfisher-macOS, generic/platform=macOS
03:59:04.105 $ git -C /Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/Kingfisher rev-parse --show-toplevel
03:59:05.964 FAIL: Kingfisher, 5.1, 44450a, Kingfisher-tvOS, generic/platform=tvOS
03:59:06.065 $ git -C /Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/Kingfisher rev-parse --show-toplevel
03:59:07.918 FAIL: Kingfisher, 5.1, 44450a, Kingfisher-watchOS, generic/platform=watchOS

@shahmishal
Copy link
Member

xcodebuild: error: The workspace named "Kingfisher" does not contain a scheme named "Kingfisher-macOS". The "-list" option can be used to find the names of the schemes in the workspace.

@onevcat
Copy link
Contributor

onevcat commented Apr 22, 2021

:( Ah, it seems that Xcode schemes are used! (I thought it is already using SPM) These schemes also needs update. I will submit a new PR!

@onevcat
Copy link
Contributor

onevcat commented Apr 22, 2021

@shahmishal Sorry for the confusion but #528 should bring the tests back to normal.

@shahmishal
Copy link
Member

@onevcat Thanks!

@shahmishal
Copy link
Member

@clackary We can close this PR in favor of #528

@clackary clackary closed this Apr 22, 2021
@clackary clackary deleted the drop-kingfisher-4.0 branch April 22, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants