-
Notifications
You must be signed in to change notification settings - Fork 153
Drop Kingfisher 4.0 configuration #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@onevcat Hi there, just wanted to let you know we've removed the 4.0 configuration for Kingfisher because a5d1214220b8ddf29acf7c08c8bb42993ed56c54 doesn't appear to exist on Kingfisher:master branch. Feel free to add this configuration again with a different commit! |
@swift-ci test |
Oh bummer, it looks like the 5.1 configuration is failing in the same way.
I'll try a different commit here. |
@swift-ci test |
I did a git reflog recently and I will update the config file soon! |
Oh! Just saw that you've already gotten a new commit hash for Swift 5.1. That should be fine now since Kingfisher will not support Swift 4.x in the latest versions. There is no change from me. LGTM! |
|
|
:( Ah, it seems that Xcode schemes are used! (I thought it is already using SPM) These schemes also needs update. I will submit a new PR! |
@shahmishal Sorry for the confusion but #528 should bring the tests back to normal. |
@onevcat Thanks! |
Pull Request Description
Drops Kingfisher configuration for 4.0, as the commit reference in projects.json no longer exists on the branch.