Skip to content

Re-enable swift-numerics #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Re-enable swift-numerics #680

merged 2 commits into from
Aug 10, 2022

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Jul 12, 2022

This project should be fixed by swiftlang/swift#60008 and apple/swift-numerics#233.

Reverts #678

@xymus
Copy link
Contributor Author

xymus commented Jul 12, 2022

@swift-ci test

@shahmishal
Copy link
Member

/Users/ec2-user/jenkins/workspace/swift-PR-source-compat-suite-test-macOS/swift-source-compat-suite/project_cache/swift-numerics/Sources/_TestSupport/Error.swift:21:13: error: cannot use conformance of 'Float' to 'Real' here; 'RealModule' was not imported by this file
public func componentwiseError(_ tst: Complex<Float>, _ ref: Complex<Double>) -> Double {

@justice-adams-apple
Copy link
Collaborator

Hi @xymus 👋 , I think you'll need to bump up the revision of the swift-numerics project in the projects.json in order to contain your fix from apple/swift-numerics#233. That should get the build passing and allow us to remove the xfail

This commit has the project-side fix.
@xymus
Copy link
Contributor Author

xymus commented Aug 9, 2022

Thanks for the reminder!

@swift-ci test

Copy link
Collaborator

@justice-adams-apple justice-adams-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @xymus !

@xymus xymus merged commit a40cecf into main Aug 10, 2022
@xymus xymus deleted the revert-678-wrangle/20220705/1 branch August 10, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants