[Sema] Report exported uses of conformances that are implicitly imported #60008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnose uses of conformances in API when the conformance declaration isn't imported by the local file. This uses the existing logic checking for conformance availability combined with the implicit import check. Report it as a warning until Swift 6 where it will be an error. rdar://96437311
|
@swift-ci Please smoke test |
tshortli
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose uses of conformances in API when the conformance declaration isn't imported by the local file. This uses the existing logic checking for conformance availability combined with the implicit import check, we just needed to update the diagnostic select block. Report it as a warning until Swift 6 where it will be an error.
rdar://96437311