XFAIL failing projects #818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://109999674 rdar://109999583
hamishknight
requested review from
shahmishal and
justice-adams-apple
as code owners
|
@swift-ci please test |
|
Erik is working on a fix for this, so hopefully we won't need this, but going to keep open for now just in case |
| "tags": "sourcekit-disabled swiftpm", | ||
| "xfail": [ | ||
| { | ||
| "issue": "rdar://109999583", |
There was a problem hiding this comment.
This only affects release builds I believe you'll need
"configuration": "release"There was a problem hiding this comment.
Good catch! Though fortunately I don't think we'll need this PR after all
There was a problem hiding this comment.
Even better 👍
| "tags": "sourcekit-disabled swiftpm", | ||
| "xfail": [ | ||
| { | ||
| "issue": "rdar://109999583", |
There was a problem hiding this comment.
This only affects debug builds I believe you'll need
"configuration": "debug"
|
The issue should be fixed by swiftlang/swift#66238, so we shouldn't need this after all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://109999674
rdar://109999583