Skip to content

XFAIL failing projects #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 54 additions & 6 deletions projects.json
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,15 @@
"action": "BuildSwiftPackage",
"build_tests": "true",
"configuration": "release",
"tags": "sourcekit-disabled swiftpm"
"tags": "sourcekit-disabled swiftpm",
"xfail": [
{
"issue": "rdar://109999583",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects debug builds I believe you'll need

"configuration": "debug"

"compatibility": ["4.2", "5.1", "5.3", "5.7"],
"branch": ["main"],
"job": ["source-compat"]
}
]
},
{
"action": "TestSwiftPackage"
Expand Down Expand Up @@ -973,7 +981,15 @@
"action": "BuildSwiftPackage",
"build_tests": "true",
"configuration": "release",
"tags": "sourcekit-disabled swiftpm"
"tags": "sourcekit-disabled swiftpm",
"xfail": [
{
"issue": "rdar://109999583",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects release builds I believe you'll need

"configuration": "release"

Copy link
Contributor Author

@hamishknight hamishknight May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Though fortunately I don't think we'll need this PR after all

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better 👍

"compatibility": "5.0",
"branch": ["main"],
"job": ["source-compat"]
}
]
},
{
"action": "TestSwiftPackage"
Expand Down Expand Up @@ -1950,14 +1966,30 @@
"target": "ProcedureKit",
"destination": "platform=macOS",
"configuration": "Release",
"tags": "sourcekit-disabled"
"tags": "sourcekit-disabled",
"xfail": [
{
"issue": "rdar://109999674",
"compatibility": ["4.2", "5.0"],
"branch": ["main"],
"job": ["source-compat"]
}
]
},
{
"action": "BuildXcodeProjectTarget",
"project": "ProcedureKit.xcodeproj",
"target": "ProcedureKit",
"destination": "generic/platform=iOS",
"configuration": "Release"
"configuration": "Release",
"xfail": [
{
"issue": "rdar://109999674",
"compatibility": ["4.2", "5.0"],
"branch": ["main"],
"job": ["source-compat"]
}
]
},
{
"action": "BuildXcodeProjectTarget",
Expand All @@ -1979,15 +2011,31 @@
"project": "ProcedureKit.xcodeproj",
"target": "ProcedureKit",
"destination": "generic/platform=tvOS",
"configuration": "Release"
"configuration": "Release",
"xfail": [
{
"issue": "rdar://109999674",
"compatibility": ["4.2", "5.0"],
"branch": ["main"],
"job": ["source-compat"]
}
]
},
{
"action": "BuildXcodeProjectTarget",
"project": "ProcedureKit.xcodeproj",
"target": "ProcedureKitCloud",
"destination": "platform=macOS",
"configuration": "Release",
"tags": "sourcekit-disabled"
"tags": "sourcekit-disabled",
"xfail": [
{
"issue": "rdar://109999674",
"compatibility": ["4.2", "5.0"],
"branch": ["main"],
"job": ["source-compat"]
}
]
},
{
"action": "TestXcodeProjectTarget",
Expand Down