Remove Foundation dependency in SwiftSyntaxBuilder #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using a `NSRegularExpression` to count the number of #'s. Walk through the contents of the string and count them directly. Resolves rdar://101503176.
bnbarham
force-pushed
the
string-literal-no-regex
branch
from
933494b to
37595c1
Compare
|
@swift-ci please test |
|
Interesting, that dependency has been there for a while. Did we recently start building SwiftSyntaxBuilder into the compiler? |
Yes, as part of pulling the builtin macros into the compiler |
This was referenced Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using a
NSRegularExpressionto count the number of #'s. Walk through the contents of the string and count them directly.Resolves rdar://101503176.