build: add dependency on Foundation #1026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
force-pushed
the
foundation-repairs
branch
from
0f8e018 to
c93139b
Compare
|
@swift-ci please test |
|
No, we shouldn't need this. We accidentally grew one Foundation dependency and have removed it in #1016. |
Now that Foundation is required for SwiftSyntax, add the ability to tie together build trees and bootstrap SwiftSyntax. This is required to repair the Windows build.
compnerd
force-pushed
the
foundation-repairs
branch
from
c93139b to
4cff745
Compare
CodaFi
requested changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Foundation is required for SwiftSyntax, add the ability to tie together build trees and bootstrap SwiftSyntax. This is required to repair the Windows build.