Skip to content

Fix trailing space on as, init and try keyword #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fix trailing space on as, init and try keyword #1137

merged 1 commit into from
Dec 14, 2022

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Dec 12, 2022 •
edited
Loading

Currently the parser makes ReturnStmt("return self.asProtocol(SyntaxProtocol.self) as? DeclSyntaxProtocol") into return self.asProtocol(SyntaxProtocol.self) as ? DeclSyntaxProtocol

Fixes #1141
Fixes #1115

@kimdv kimdv requested a review from ahoppen as a code owner December 12, 2022 10:46
@kimdv kimdv changed the title Fix trailing space on as keyword Fix trailing space on as keyword Dec 12, 2022
@kimdv kimdv force-pushed the kimdv/fix-trailing-space-in-as-keyword branch 2 times, most recently from d38e4f0 to 194ae70 Compare December 13, 2022 09:45
@kimdv
Copy link
Contributor Author

kimdv commented Dec 13, 2022

@swift-ci please test

ahoppen
ahoppen reviewed Dec 13, 2022
View reviewed changes
@kimdv kimdv force-pushed the kimdv/fix-trailing-space-in-as-keyword branch from 194ae70 to db621a2 Compare December 13, 2022 11:19
@kimdv
Copy link
Contributor Author

kimdv commented Dec 13, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/fix-trailing-space-in-as-keyword branch 2 times, most recently from 18d9af7 to 66c209f Compare December 14, 2022 07:12
@kimdv
Copy link
Contributor Author

kimdv commented Dec 14, 2022

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/fix-trailing-space-in-as-keyword branch from 66c209f to 6203147 Compare December 14, 2022 07:49
@kimdv kimdv force-pushed the kimdv/fix-trailing-space-in-as-keyword branch from 6203147 to 8328666 Compare December 14, 2022 07:51
@kimdv kimdv changed the title Fix trailing space on as keyword Fix trailing space on as, init and try keyword Dec 14, 2022
@kimdv
Copy link
Contributor Author

kimdv commented Dec 14, 2022

@swift-ci please test

ahoppen
ahoppen approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks good 👍

@kimdv kimdv merged commit fd2f742 into swiftlang:main Dec 14, 2022
@kimdv kimdv deleted the kimdv/fix-trailing-space-in-as-keyword branch December 14, 2022 14:17
@stevapple stevapple mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@stevapple stevapple stevapple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SwiftBasicFormat isn't formatting try? correctly Default init style from SwiftBasicFormat looks unfamiliar
3 participants
@kimdv @ahoppen @stevapple