Skip to content

Fix trailing space on init keyword #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2022
Merged

Fix trailing space on init keyword #1147

merged 2 commits into from
Dec 15, 2022

Conversation

stevapple
Copy link
Contributor

Minor fix-up to #1137 which solves the problem of BasicFormat formatting init() into init ().

@stevapple stevapple requested a review from ahoppen as a code owner December 15, 2022 03:56
@stevapple stevapple mentioned this pull request Dec 15, 2022
Merged
kimdv
kimdv reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@kimdv kimdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevapple, I made some in line comments

@kimdv kimdv mentioned this pull request Dec 15, 2022
Merged
1 task
@kimdv
Copy link
Contributor

kimdv commented Dec 15, 2022

@swift-ci please test

@kimdv
Copy link
Contributor

kimdv commented Dec 15, 2022

Thanks! 🎉

ahoppen
ahoppen approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix and welcome to SwiftSyntax’s development.

@ahoppen ahoppen merged commit 46cc7c0 into swiftlang:main Dec 15, 2022
@stevapple stevapple deleted the init-space branch December 15, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@kimdv kimdv kimdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevapple @kimdv @ahoppen