Skip to content

Mark function parameters and tuple elements as indented #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 15, 2022
Merged

Mark function parameters and tuple elements as indented #1148

merged 7 commits into from
Dec 15, 2022

Conversation

stevapple
Copy link
Contributor

RT, this will allow SwiftBasicFormat to indent a multiline

  • TupleTypeElementList
  • TupleExprElementList
  • FunctionParameterList

more nicely.

@stevapple stevapple requested a review from ahoppen as a code owner December 15, 2022 04:09
@stevapple
Copy link
Contributor Author

One of the tests depends on the style update in #1147, so that should be tested with & merged ahead

@stevapple stevapple mentioned this pull request Dec 15, 2022
Merged
1 task
kimdv
kimdv reviewed Dec 15, 2022
View reviewed changes
@kimdv
Copy link
Contributor

kimdv commented Dec 15, 2022

@swift-ci please test

ahoppen
ahoppen approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for the fix and all the test cases. Looks good to me 👍

@kimdv kimdv merged commit 40b8304 into swiftlang:main Dec 15, 2022
@stevapple stevapple deleted the tuple-indent branch December 15, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@kimdv kimdv kimdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevapple @kimdv @ahoppen