Remove the typealiases in SwiftSyntaxBuilder that refer to syntax nodes without the Syntax suffix
#1183
+1,052
−1,625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
approved these changes
Jan 4, 2023
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxbuilder-typealias
branch
from
d2b895d to
a6ee7e3
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxbuilder-typealias
branch
from
a6ee7e3 to
3c7b226
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxbuilder-typealias
branch
from
3c7b226 to
9989334
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxbuilder-typealias
branch
from
9989334 to
b6bd54a
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxbuilder-typealias
branch
from
b6bd54a to
3161a4e
Compare
|
@swift-ci Please test |
…es without the `Syntax` suffix In the past, before SwiftSyntaxBuilder shared the same syntax nodes with SwiftSyntax, it made sense for it to have its own syntax nodes and thus drop the `Syntax` suffix. But since SwiftSyntaxBuilder is now just providing convenience initializers, it’s confusing to have two names to refer to the same type - the style was already pretty inconsitent in this code base. To make things consistent, drop the typealiases.
ahoppen
force-pushed
the
ahoppen/remove-swiftsyntaxbuilder-typealias
branch
from
3161a4e to
6df9357
Compare
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Jan 13, 2023
swiftlang#1183 and swiftlang#1218 raced to create a build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, before SwiftSyntaxBuilder shared the same syntax nodes with SwiftSyntax, it made sense for it to have its own syntax nodes and thus drop the
Syntaxsuffix.But since SwiftSyntaxBuilder is now just providing convenience initializers, it’s confusing to have two names to refer to the same type - the style was already pretty inconsitent in this code base. To make things consistent, drop the typealiases.