Fix spacings around !and ?
#1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kimdv
force-pushed
the
kimdv/fix-spacing-pt-2
branch
from
b96ea09 to
021c2a4
Compare
|
@swift-ci please test |
ahoppen
reviewed
Jan 11, 2023
There was a problem hiding this comment.
This makes me wonder whether the better default would be to mark exclamationMark and postfixQuestionMark as not having a trailing space and selectively enabling it in cases where we want a trailing space.
I’m thinking that in the most cases the exclamation and question mark will be appended to an identifier and since identifiers don’t have a trailing space, ! and ? also shouldn’t have a trailing space. I might be wrong though.
|
I can see what happens 😬 |
kimdv
force-pushed
the
kimdv/fix-spacing-pt-2
branch
from
021c2a4 to
51d94a0
Compare
|
@swift-ci please test |
ahoppen
reviewed
Jan 12, 2023
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/fix-spacing-pt-2
branch
from
51d94a0 to
afc428e
Compare
kimdv
force-pushed
the
kimdv/fix-spacing-pt-2
branch
from
afc428e to
c96d707
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Jan 13, 2023
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Jan 13, 2023
swiftlang#1183 and swiftlang#1218 raced to create a build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some spacing regressions found in #1217