Skip to content

Remove deprecated methods #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 10, 2023

Now that we have branched for Swift 5.8, we can remove all deprecated methods on main.

@ahoppen ahoppen requested review from rintaro and bnbarham January 10, 2023 10:05
@ahoppen ahoppen force-pushed the ahoppen/remove-deprecated-methods branch from b0ecca8 to e458917 Compare January 10, 2023 10:09
@ahoppen
Copy link
Member Author

ahoppen commented Jan 10, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jan 10, 2023

Holding this back to make cherry-picking changes from main to release/5.8 easier.

@ahoppen ahoppen marked this pull request as draft January 10, 2023 19:49
@ahoppen ahoppen force-pushed the ahoppen/remove-deprecated-methods branch from e458917 to 0e60fd1 Compare February 2, 2023 07:38
@ahoppen ahoppen marked this pull request as ready for review February 2, 2023 07:38
@ahoppen
Copy link
Member Author

ahoppen commented Feb 2, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/remove-deprecated-methods branch 2 times, most recently from 6c81b91 to 0bff793 Compare February 2, 2023 15:55
@ahoppen
Copy link
Member Author

ahoppen commented Feb 2, 2023

@swift-ci Please test

@bnbarham
Copy link
Contributor

bnbarham commented Feb 2, 2023

−9,559

That's the kind of number I like to see :). Thanks Alex!

@ahoppen
Copy link
Member Author

ahoppen commented Feb 2, 2023

swiftlang/swift#63387

@swift-ci Please test

Now that we have branched for Swift 5.8, we can remove all deprecated methods on main.
@ahoppen ahoppen force-pushed the ahoppen/remove-deprecated-methods branch from 4d48809 to 9d9d62d Compare February 4, 2023 10:09
@ahoppen
Copy link
Member Author

ahoppen commented Feb 4, 2023

swiftlang/swift#63387

@swift-ci Please test

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Feb 4, 2023

swiftlang/swift#63387

@swift-ci Please test

@ahoppen ahoppen merged commit 3ac962d into swiftlang:main Feb 7, 2023
@ahoppen ahoppen deleted the ahoppen/remove-deprecated-methods branch February 7, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants