Skip to content

[Macros] Compile Macros tests with swift-version 5 instead of swift-version 4 #63387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Feb 2, 2023

Lit-tests still use language version 4 by default. This is causing issues when removing the default string interpolation without a label in swiftlang/swift-syntax#1210 because Swift 4 didn’t support labeled string interpolation.

@ahoppen ahoppen force-pushed the ahoppen/macros-swift-5 branch from 3dc7e2e to ba5a727 Compare February 4, 2023 10:10
@ahoppen
Copy link
Member Author

ahoppen commented Feb 6, 2023

@swift-ci Please smoke test

@ahoppen ahoppen merged commit 75771c1 into swiftlang:main Feb 7, 2023
@ahoppen ahoppen deleted the ahoppen/macros-swift-5 branch February 7, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant