[5.8] Cherry-pick most changes from main to release/5.8
#1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-from-gyb-to-code-gen Move SyntaxVisitor from gyb to codegen
…ion-gyb-to-codegen
Make use of AttributedSyntax to handle all declarations with macro attributes.
While doing this, also move CODEOWNERS to .github folder
These nodes weren’t used in SwiftParser, so we can remove them. rdar://103448455
…nodes Remove unused nodes
…ind-from-gyb-to-code-gen
…eralize Generalize macro expansion for macros written as attributes
Make Doug code owner of macros and Swift operators
This property isn't used anywhere, dates back to the old parser and isn't public. Let's remove it.
…StringLiteral` This removes the implicit expressibility by string literals for all decl/stmt/... nodes, which parsed the node as a decl/stmt/... and then cast it to the expected type. rdar://104090218
…iterals Diagnose singe-line strings
Fixes swiftlang#1119 rdar://103048943
…eywords Remove pound keywords token kinds
…-colored-diagnostics Implement support for automatically coloring output in DiagnosticsFormatter
…s-expressible-by-string Don’t automaticaly conform all decl/stmt/etc. nodes to `ExpressibleByStringLiteral`
…ibute-recovery Improve recovery of misplaced attributes on statements
…ement-diagnostic Improve diagnostic if where clause is missing a requirement
…onfig Parse attributes in `#if`
…word-raw-values Don't output raw values for `Keyword` enum members
This was referenced Jan 27, 2023
jpsim
added a commit
to realm/SwiftLint
that referenced
this pull request
Jan 27, 2023
jpsim
added a commit
to realm/SwiftLint
that referenced
this pull request
Jan 27, 2023
hborla
approved these changes
Jan 31, 2023
|
After some discussion we decided that this is too risky to cherry-pick into 5.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been major API redesigns in swift-syntax in the last couple of weeks. To make transitioning clients to the new API easier, we are cherry-picking all of those changes to
release/5.8. That way, only one adjustment is needed when updating to 5.8 instead of having to update when adopting 5.8 and requiring more significant changes when updating to 5.9.The only PR that will not be cherry-picked to
release/5.8is #1167 because it requires significant changes in apple/swift. @hborla Could you verify that I correctly reverted that patch in 841c0ec? I am fairly confident I did it correctly, but it’s always good to double-check.