Skip to content

Move SyntaxCollections from gyb to codegen #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Move SyntaxCollections from gyb to codegen #1186

merged 1 commit into from
Jan 9, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Jan 4, 2023 •
edited
Loading

Part of #1158

@kimdv kimdv requested a review from ahoppen as a code owner January 4, 2023 21:01
@kimdv
Copy link
Contributor Author

kimdv commented Jan 4, 2023

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/move-syntaxcollection-gyb-to-codegen branch from 8891b38 to b79345b Compare January 4, 2023 21:27
@kimdv kimdv force-pushed the kimdv/move-syntaxcollection-gyb-to-codegen branch 2 times, most recently from bc198a0 to 3ee9af3 Compare January 5, 2023 11:06
@kimdv
Copy link
Contributor Author

kimdv commented Jan 5, 2023

@swift-ci please test

@kimdv kimdv requested a review from ahoppen January 5, 2023 11:58
ahoppen
ahoppen approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always: Thank you for those changes!

Can we hold back merging this until #1193 is merged? I think the two will conflict and that PR is fixing a more serious bug.

@kimdv kimdv force-pushed the kimdv/move-syntaxcollection-gyb-to-codegen branch from 3ee9af3 to ab57d5d Compare January 7, 2023 09:21
@kimdv
Copy link
Contributor Author

kimdv commented Jan 7, 2023

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/move-syntaxcollection-gyb-to-codegen branch from ab57d5d to 41a87f7 Compare January 9, 2023 08:03
@kimdv
Copy link
Contributor Author

kimdv commented Jan 9, 2023

@swift-ci please test

@kimdv kimdv merged commit 7c8540b into swiftlang:main Jan 9, 2023
@kimdv kimdv deleted the kimdv/move-syntaxcollection-gyb-to-codegen branch January 9, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimdv @ahoppen