Move gyb files #1158
Closed
Move gyb files #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/move-gyb-files
branch
from
064f1d9 to
eb875f4
Compare
|
@swift-ci please test |
4 tasks
kimdv
force-pushed
the
kimdv/move-gyb-files
branch
2 times, most recently
from
7079d45 to
873e9f4
Compare
# Conflicts: # Package.swift # Sources/SwiftSyntax/generated/SyntaxTraits.swift
kimdv
force-pushed
the
kimdv/move-gyb-files
branch
from
3882177 to
db80ba9
Compare
|
Thanks for killing the remaining gyb. When the dependencies are merged, could you open separate PRs for the individual files? That makes reviewing them easier. You can also open a PR for Character.swift and I’ll try to figure out what’s going wrong. |
This was referenced Dec 29, 2022
Merged
This was referenced Jan 7, 2023
|
Closing in favour of individual PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another PR moving gyb files to swift code gen ☠️
inkeyword #1161TupleExprElementconvenience initializer #1162<,>,*,!and?#1164I'm not able to move the Trivia.swift.gyb because of
Swift/Character.swift:177: Fatal error: Can't form a Character from a String containing more than one extended grapheme clusterEven we have it in raw strings using
#it's not working.