Move generation to a single executable #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/move-to-single-generation-cli
branch
from
b013586 to
346ab29
Compare
ahoppen
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Much cleaner. Thank you.
One additional thing I’ve got on my wish list (doesn’t have to be part of this PR): Add a parameter to generate-swiftsyntax to only generate a single file. I would have found this useful while debugging why a file wasn’t generated the way I expected.
CodeGeneration/Sources/generate-swiftsyntax/GenerateSwiftSyntax.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/move-to-single-generation-cli
branch
3 times, most recently
from
d304662 to
e22eee1
Compare
kimdv
force-pushed
the
kimdv/move-to-single-generation-cli
branch
from
e22eee1 to
481f651
Compare
ahoppen
approved these changes
Dec 27, 2022
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I open this PR with some initial ideas so we can start discuss on the solution.