Move gyb files to codegen #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/move-gyb-files-to-codegen
branch
5 times, most recently
from
4f1eb2a to
ca10674
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Dec 14, 2022
kimdv
force-pushed
the
kimdv/move-gyb-files-to-codegen
branch
2 times, most recently
from
947e5ba to
ad3ddf3
Compare
This was referenced Dec 15, 2022
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/move-gyb-files-to-codegen
branch
from
ad3ddf3 to
b386e40
Compare
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/move-gyb-files-to-codegen
branch
2 times, most recently
from
4400ab4 to
5948de5
Compare
|
@ahoppen will you review again? |
kimdv
commented
Dec 16, 2022
CodeGeneration/Sources/generate-swiftsyntax/SyntaxBaseNodesFile.swift
Outdated
Show resolved
Hide resolved
kimdv
commented
Dec 16, 2022
kimdv
force-pushed
the
kimdv/move-gyb-files-to-codegen
branch
from
5948de5 to
fcf6619
Compare
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/move-gyb-files-to-codegen
branch
from
fcf6619 to
7dc8c44
Compare
|
@swift-ci please test |
ahoppen
reviewed
Dec 16, 2022
CodeGeneration/Sources/generate-swiftsyntax/SyntaxBaseNodesFile.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/move-gyb-files-to-codegen
branch
from
7dc8c44 to
fbc1903
Compare
ahoppen
approved these changes
Dec 16, 2022
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.