-
Notifications
You must be signed in to change notification settings - Fork 440
Add missing code for parser entry template and fix build-script.py
#1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
The error was properly introduced in #1149 where we refactored the code-gen into a single executable. Not sure why the CI didn't catch that before |
@swift-ci please test |
build-script.py
@kimdv looks like things don't build without this, is it good to merge? |
@swift-ci please test and merge |
Let's merge and do post-commit review if needed to unblock folks |
@keith this broke the build: https://ci.swift.org/job/oss-swift-incremental-RA-macos/2331/. I am going to try reverting it. |
dang, sorry, thanks! looks like we need to run the integration tests before merging again |
We don’t verify that the CodeGenerated files match the templates because running code generation requires us to check out an older version of SwiftSyntax (the one specified in the Package.swift of CodeGeneration). But CI doesn’t have internet access at that point to perform that checkout… So it’s a little tricky to do. |
In #1346 code was modified on the file and not in the template