Fix spacing around <, >, *, ! and ?
#1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/fix-spacing
branch
from
eace5a9 to
2928570
Compare
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/fix-spacing
branch
from
36dc856 to
6656208
Compare
kimdv
changed the title
< and > and *<, >, *, ! and ?
ahoppen
reviewed
Dec 27, 2022
There was a problem hiding this comment.
I’ve got a few test cases that I think would be interesting and suspect that some of them will break with your changes 😬 Sorry.
myOptional!.somePropertylhs < rhslhs > rhs(lhs1, lhs2) < (rhs1, rhs2)MyGeneric<String>!(an implicitly unwrapped generic type)!(true)
If you want to fix the formatting of < in generics, I think it might need to be explicitly done inside the generic parameter clause. I don’t think we’ve got any precedence for that though.
CodeGeneration/Sources/generate-swiftbasicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftbasicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/fix-spacing
branch
from
c64b8c7 to
4922721
Compare
|
Add test cases for
|
kimdv
force-pushed
the
kimdv/fix-spacing
branch
from
4922721 to
e7abba8
Compare
|
@ahoppen I've added tests cases with the examples you suggested. It seems to work. 😬 |
ahoppen
reviewed
Jan 4, 2023
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/fix-spacing
branch
3 times, most recently
from
17081bb to
4e025d2
Compare
ahoppen
reviewed
Jan 8, 2023
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/fix-spacing
branch
from
4e025d2 to
8b022d3
Compare
ahoppen
approved these changes
Jan 10, 2023
kimdv
force-pushed
the
kimdv/fix-spacing
branch
from
8b022d3 to
b32e5e2
Compare
kimdv
force-pushed
the
kimdv/fix-spacing
branch
from
b32e5e2 to
a3ef115
Compare
|
@swift-ci please test |
ahoppen
reviewed
Jan 10, 2023
Comment on lines
+165
to
+166
| (.postfixQuestionMark, .rightAngle), // Ensures there is not space in `ContiguousArray<RawSyntax?>` | ||
| (.postfixQuestionMark, .rightParen), // Ensures there is not space in `myOptionalClosure?()` |
There was a problem hiding this comment.
I think those are also no longer necessary
There was a problem hiding this comment.
I see they are necessary to remove the trailing space on postfixQuestionMark
ahoppen
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes so we don't get
var newLayout: ContiguousArray < RawSyntax ? > ?when doingVariableDecl("var newLayout: ContiguousArray<RawSyntax?>?").If you can think of other test cases that I nee to add, to ensure we have expected behaviour different places feel free to comment then.
this PR also fixes #853