Skip to content

Move SyntaxRewriter from gyb to codegen #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Jan 7, 2023

Part of #1158
Depends on #1164

@kimdv kimdv requested a review from ahoppen as a code owner January 7, 2023 10:26
@kimdv kimdv force-pushed the kimdv/move-syntax-rewriter-from-gyb-to-code-gen branch from c0f42b7 to 062c047 Compare January 10, 2023 21:08
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of formatting comments, otherwise LGTM.

@kimdv kimdv force-pushed the kimdv/move-syntax-rewriter-from-gyb-to-code-gen branch from 062c047 to d01b897 Compare January 15, 2023 11:53
@kimdv kimdv force-pushed the kimdv/move-syntax-rewriter-from-gyb-to-code-gen branch from d01b897 to 2d357b1 Compare January 15, 2023 12:05
@kimdv
Copy link
Contributor Author

kimdv commented Jan 15, 2023

@swift-ci please test

@kimdv kimdv merged commit 486a86c into swiftlang:main Jan 15, 2023
@kimdv kimdv deleted the kimdv/move-syntax-rewriter-from-gyb-to-code-gen branch February 9, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants