[reference-bindings] Add support for borrow, inout bindings. #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@ahoppen do I need to update anything else? |
ahoppen
reviewed
Feb 27, 2023
There was a problem hiding this comment.
What is stopping you from just using borrow and inout as keywords here? If you want to introduce this as a staged process with new keywords for now, I think it would make sense to underscore borrowBindingKW and inoutBindingKW to indicate they aren’t the final design.
gottesmm
force-pushed
the
pr-56d5f24cde74ce112ffcd40bc4c23e08e70aae99
branch
from
a1896bd to
db1a31c
Compare
|
@swift-ci test |
gottesmm
force-pushed
the
pr-56d5f24cde74ce112ffcd40bc4c23e08e70aae99
branch
from
db1a31c to
306ac7b
Compare
|
@swift-ci test |
ahoppen
approved these changes
Feb 27, 2023
Comment on lines
+195
to
+197
| // | ||
| // NOTE: We reuse this for inout bindings and choose the higher precedence level of expr keywords | ||
| // so we do not break anything. |
There was a problem hiding this comment.
Suggested change
| // | |
| // NOTE: We reuse this for inout bindings and choose the higher precedence level of expr keywords | |
| // so we do not break anything. | |
| // | |
| // NOTE: We reuse this for inout bindings and choose the lower precedence level of expr keywords | |
| // so we don’t skip over expression keywords while looking for `inout` in an expression position. |
There was a problem hiding this comment.
@ahoppen I am going to do that in a follow on commit. I don't want to restart CI
|
@swift-ci test |
gottesmm
force-pushed
the
pr-56d5f24cde74ce112ffcd40bc4c23e08e70aae99
branch
from
306ac7b to
3b021d7
Compare
|
@swift-ci test |
…ypes. This was exposed by: decl/enum/enumtest.swift The problem here is that we are now allowing for inout to be the start of a swift decl. This means that if one defines an enum case with a inout parameter, the parser gets confused and doesnt think it is part of the type. I worked around this by changing canParseTupleTypeBody to say that an inout binding cannot be parsed as part of a tuple type. This fits already with how we want to model this.
|
This is rdar://106262176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure that I did not stomp on anything already working around borrow, inout, I decided to (for now) use the keywords inoutBindingKW and borrowBindingKW, just to be careful.