[reference-binding] Parser support for inout bindings #64012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro,
slavapestov,
hborla and
xedin
as code owners
|
@swift-ci smoke test |
…instead of a bool to mean a let. I am going to be adding more VarDecl::Introducers so this is a small nice cleanup that is cut off the larger patch.
…rnBindingState. This cleans up the parser code a little bit around here and will make it easier for me to add inout.
…ypes. This was exposed by: decl/enum/enumtest.swift The problem here is that we are now allowing for inout to be the start of a swift decl. This means that if one defines an enum case with a inout parameter, the parser gets confused and doesnt think it is part of the type. I worked around this by changing canParseTupleTypeBody to say that an inout binding cannot be parsed as part of a tuple type. This fits already with how we want to model this.
gottesmm
force-pushed
the
reference-bindings-part-1
branch
from
0274f6b to
1459d25
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
This is rdar://106262176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the initial part.