Skip to content

Remove generated note in header #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

Remove generated note in header #1396

merged 1 commit into from
Mar 9, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Mar 9, 2023

No description provided.

@kimdv kimdv requested a review from ahoppen as a code owner March 9, 2023 07:10
@kimdv
Copy link
Contributor Author

kimdv commented Mar 9, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Mar 9, 2023

@swift-ci please test windows

@kimdv kimdv mentioned this pull request Mar 9, 2023
Merged
@kimdv
Copy link
Contributor Author

kimdv commented Mar 9, 2023

@swift-ci please test windows

@kimdv
Copy link
Contributor Author

kimdv commented Mar 9, 2023

Not sure why windows fails on this one 🤔

@compnerd
Copy link
Member

compnerd commented Mar 9, 2023 

CMake Error: File C:/Users/swift-ci/jenkins/workspace/swift-syntax-PR-windows/llvm-project/llvm/stdlib/public/Cxx/std/libstdcxx.modulemap does not exist.
CMake Error at C:/Users/swift-ci/jenkins/workspace/swift-syntax-PR-windows/swift/unittests/ClangImporter/CMakeLists.txt:1 (configure_file):
  configure_file Problem configuring file

CC: @egorzhdan @zoecarver

@compnerd
Copy link
Member

compnerd commented Mar 9, 2023

This was caused by @hyp in swiftlang/swift#64177

@compnerd
Copy link
Member

compnerd commented Mar 9, 2023

Please test with following PRs:
swiftlang/swift#64241

@swift-ci please test Windows platform

@kimdv kimdv merged commit f92f133 into swiftlang:main Mar 9, 2023
@kimdv kimdv deleted the kimdv/fix-header-comments branch March 9, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimdv @compnerd @ahoppen