Skip to content

Fix issue that caused SwiftSyntax's module to not be properly installed #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 7, 2019

We were copying both the .swiftmodule and the .swiftdoc file of the module to the same path <dest_dir>/x86_64. That way one file always overwrote the other. Fix this so the files get copied to <dest_dir>/SwiftSyntax.swiftmodule/x86_64.(swiftmodule|swiftdoc)

@ahoppen
Copy link
Member Author

ahoppen commented Oct 7, 2019

swiftlang/swift#27566

@swift-ci Please test

@ahoppen ahoppen merged commit cd1e298 into swiftlang:master Oct 8, 2019
@ahoppen ahoppen deleted the install-module branch October 8, 2019 18:26
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Absorb trailing comma of function call args in grouped exprs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants