[build-script] Pass updated arguments to SwiftSyntax's build script #27566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
nkcsgexi
reviewed
Oct 7, 2019
utils/build-script-impl
Outdated
| @@ -3443,7 +3443,7 @@ for host in "${ALL_HOSTS[@]}"; do | |||
| if [ "${BUILD_LIBPARSER_ONLY}" ]; then | |||
| # We don't have a toolchain so we should install to the specified dir | |||
| DYLIB_DIR="${INSTALL_DESTDIR}" | |||
| MODULE_DIR="${INSTALL_DESTDIR}" | |||
| MODULE_DIR="${INSTALL_DESTDIR}/SwiftSyntax.swiftmodule/${SWIFT_HOST_VARIANT_ARCH}" | |||
There was a problem hiding this comment.
Can we use ${product} for SwiftSyntax here?
|
Build failed |
This fixes an issue that caused SwiftSyntax's module to not be properly installed.
ahoppen
force-pushed
the
install-swiftsyntax-module
branch
from
2cf40f2 to
c4814cb
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@ahoppen question. Can you try using the build-script toolchain approach? Rather than using build-script-impl? |
|
nm, I see you are actually doing that! Big +1 from me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the parameters passed to SwiftSyntax's build script to fix an issue that caused SwiftSyntax's module to not be properly installed.
Corresponds to swiftlang/swift-syntax#151