Skip to content

[build-script] Fix issue with installing SwiftSyntax if target dir does not exist #27576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 8, 2019

Fix an issue that I introduced in #27566 that causes the build script to fail if the target directory into which SwiftSyntax shall be installed, does not exist yet.

@ahoppen ahoppen requested a review from nkcsgexi October 8, 2019 19:49
@ahoppen
Copy link
Member Author

ahoppen commented Oct 8, 2019

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 8, 2019

Let’s test if we’re now able to build toolchains.

@swift-ci Please Build Toolchain macOS Platform
@swift-ci Please Build Toolchain Linux Platform

@ahoppen
Copy link
Member Author

ahoppen commented Oct 8, 2019

@swift-ci Please Build Toolchain macOS Platform

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2019

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 36a7e93

Install command
tar zxf swift-PR-27576-293-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2019

macOS Toolchain
Download Toolchain
Git Sha - 36a7e93

Install command
tar -zxf swift-PR-27576-394-osx.tar.gz --directory ~/

@ahoppen ahoppen merged commit 1d7d58a into swiftlang:master Oct 8, 2019
@ahoppen ahoppen deleted the install-swiftsyntax-module branch October 8, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants