Refactor SyntaxRewriter #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
akyrtzi
reviewed
Oct 15, 2019
Make the implementation of SyntaxRewriter more similar to that of SyntaxVisitor, improve performance and make SyntaxRewriter ready for future performance improvements.
ahoppen
force-pushed
the
rewriter-refactoring
branch
from
b23eb43 to
1d5126f
Compare
akyrtzi
approved these changes
Oct 15, 2019
| open func visit(_ token: TokenSyntax) -> Syntax { | ||
| return token | ||
| } | ||
|
|
||
| /// Visit a `UnknownSyntax`. |
harlanhaskins
approved these changes
Oct 15, 2019
|
@swift-ci Please test |
|
Build failed |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
minor sp: continution --> continuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of
SyntaxRewriterto make it more similar toSyntaxVisitor. This is motivated by three things:a) It increases the rewriter performance by 1.9x
b) It gets
SyntaxRewriterready for upcoming performance improvements (switch Syntax's representation to bestruct-based)c) It makes the two codebases more similar, allowing easier maintenance.