Skip to content

Make node descriptions multi-line #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Nov 4, 2019

Node descriptions were specified as being single-line in gyb_syntax_support even though they were printed as multi-line in SwiftSyntax. Changing the node description to be multi-line in gyb_syntax_support makes them correctly show up as multi-line here.

Companion PR to swiftlang/swift#27945

Node descriptions were specified as being single-line in
gyb_syntax_support even though they were printed as multi-line in
SwiftSyntax. Changing the node description to be multi-line in
gyb_syntax_support makes them correctly show up as multi-line here.
@ahoppen
Copy link
Member Author

ahoppen commented Nov 4, 2019

swiftlang/swift#27945

@swift-ci Please test

@ahoppen ahoppen requested a review from harlanhaskins November 4, 2019 16:34
@ahoppen ahoppen merged commit ed00260 into swiftlang:master Nov 5, 2019
@ahoppen ahoppen deleted the multiline-generated-comments branch November 5, 2019 04:04
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Move conditional compilation directive inside tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants