Skip to content

[gyb_syntax_support] Make node descriptions multi-line #27945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 29, 2019

The node descriptions are printed as dedented multi-line strings when the corresponding files are being generated in SwiftSyntax. To do this, however, the strings need to be multi-line to begin with and not have the line break escaped.

The node descriptions are printed as dedented multi-line strings when
the corresponding files are being generated in SwiftSyntax. To do this,
however, the strings need to be multi-line to begin with and not have
the line break escaped.
@ahoppen
Copy link
Member Author

ahoppen commented Oct 29, 2019

To merge this PR I need to update the corresponding generated gyb files. Letting CI run without the updated files to make sure we catch it if someone forgets to update the gyb files.

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1ebf2f2

@ahoppen
Copy link
Member Author

ahoppen commented Nov 4, 2019

swiftlang/swift-syntax#170

@swift-ci Please test

@ahoppen ahoppen merged commit 96a38f6 into swiftlang:master Nov 5, 2019
@ahoppen ahoppen deleted the multiline-generated-comments branch November 5, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants