Add missing trait conformances #1784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 14, 2023
These trait conformances were simply missing. Add them.
ahoppen
force-pushed
the
ahoppen/missing-traits
branch
from
8a1192e to
c46097b
Compare
ahoppen
commented
Jun 14, 2023
| @@ -1112,7 +1112,7 @@ final class MacroSystemTests: XCTestCase { | |||
| expandedSource: #""" | |||
| struct S { | |||
| @attr static var value1 = 1 | |||
| @attr typealias A = B | |||
| @attr static typealias A = B | |||
There was a problem hiding this comment.
@rintaro I assume that the addition of static here is expected, right?
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These trait conformances were simply missing. Add them.
I added a validation rule to check that all nodes that can conform to a trait do so in #1748.