Skip to content

Use rewrite func instead of visit for SyntaxRewriter #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

Use rewrite func instead of visit for SyntaxRewriter #1939

merged 1 commit into from
Jul 25, 2023
+6 −6

Conversation

kitasuke
Copy link
Contributor

In my opinion, using rewrite func is a bit easier to understand for SyntaxRewriter. visit func can literally be used to visit for SyntaxVisitor instead.

ahoppen
ahoppen approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, rewrite should indeed be used instead of visit.

@ahoppen
Copy link
Member

ahoppen commented Jul 25, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit 4cfb370 into swiftlang:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitasuke @ahoppen