Remove the last lit test #2160
Merged
Remove the last lit test #2160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only had a single lit test left, which was testing the integration of the macro plugin with the compiler. That testing should be covered by us building the macro examples in the `Examples` package, so it’s not needed anymore. rdar://114469622
|
@swift-ci Please test |
bnbarham
approved these changes
Sep 6, 2023
kimdv
approved these changes
Sep 7, 2023
Matejkob
reviewed
Sep 7, 2023
There was a problem hiding this comment.
I'm wondering if we still need the ExamplePlugin target in the Examples package - was it mainly used for lit tests, and is it now a bit redundant with MacroExamples?
|
Yes, I think merging the two targets would make sense. Could you be interested in doing that, @Matejkob? |
|
Sure, I've added an issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only had a single lit test left, which was testing the integration of the macro plugin with the compiler. That testing should be covered by us building the macro examples in the
Examplespackage, so it’s not needed anymore.rdar://114469622