Run CodeGeneration tests in CI #2171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
natikgadzhi
reviewed
Sep 8, 2023
| @@ -24,9 +24,8 @@ struct Test: ParsableCommand, BuildCommand { | |||
| var arguments: BuildArguments | |||
|
|
|||
| func run() throws { | |||
| try buildExample(exampleName: "ExamplePlugin") | |||
There was a problem hiding this comment.
Curious, and unrelated to the PR: why remove the buildExample step? Do we build in another command now? (Just learning about the scripts, and will read more — very likely that I'll stumble at the answer on my own in 5 minutes)
There was a problem hiding this comment.
Oh, we needed to build the example for the lit test, which I removed in #2160. I just forgot to remove buildExample in that PR.
| "SWIFTPARSER_ENABLE_ALTERNATE_TOKEN_INTROSPECTION": "1", | ||
| ] | ||
|
|
||
| try invokeSwiftPM( |
ahoppen
force-pushed
the
ahoppen/run-codegen-tests
branch
from
9bfe8f0 to
e208fe5
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Sep 8, 2023
kimdv
approved these changes
Sep 8, 2023
ahoppen
force-pushed
the
ahoppen/run-codegen-tests
branch
from
e208fe5 to
0f66693
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test |
With the migration of build-script.py to Swift, we accidentally dropped running the CodeGeneration tests. Re-enable them.
ahoppen
force-pushed
the
ahoppen/run-codegen-tests
branch
from
0f66693 to
9dfc532
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the migration of build-script.py to Swift, we accidentally dropped running the CodeGeneration tests. Re-enable them.