Add @implementation to parser #2570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
reviewed
Mar 27, 2024
| @@ -550,6 +551,8 @@ public enum Keyword: CaseIterable { | |||
| return KeywordSpec("higherThan") | |||
| case .if: | |||
| return KeywordSpec("if", isLexerClassified: true) | |||
| case .implementation: | |||
| return KeywordSpec("implementation") | |||
There was a problem hiding this comment.
Could you mark the keyword as experimental, eg. like _borrowing. For that you’ll need to plumb the experimental feature through.
beccadax
force-pushed
the
objcimpl-real-name
branch
from
27a150e to
f347b2f
Compare
|
In further discussions with @ahoppen, it became clear that I don't really need to modify SwiftSyntax for this—we can parse it as a custom attribute and convert it to a built-in attribute in ASTGen. Gonna close this PR and do that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches swiftlang/swift#72596.