Add @implementation and feature flags for objcImpl #72596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
|
With swiftlang/swift-syntax#2570 @swift-ci please test |
|
With swiftlang/swift-syntax#2570 @swift-ci please test |
tshortli
reviewed
Mar 27, 2024
tshortli
approved these changes
Mar 27, 2024
They will eventually have slightly different deprecation status and error behavior, but not yet. Fixes rdar://110728033.
They will have slightly different enablement and diagnostic behavior in a future commit.
• ObjCImplementation controls @implementation on extensions • CImplementation controls @implementation and @_objcImplementation on cdecl functions Why the difference between them? Because `@_objcImplementation extension` has already been adopted pretty widely, while `@_objcImplementation @_cdecl` is very new.
…only when the ObjCImplementation experimental language feature is enabled. (`@implementation extension` is the preferred form.)
Adopting @implementation turns all of the warnings into errors.
Helps allow test/decl/ext/cdecl_implementation.swift to run on non-ObjC platforms.
beccadax
force-pushed
the
objcimpl-real-name
branch
from
3f18cea to
0505c38
Compare
|
With swiftlang/swift-syntax#2570 @swift-ci please test |
tshortli
reviewed
Mar 28, 2024
|
|
||
| // YES-DAG: cdecl_implementation_features.swift:[[@LINE+4]]:{{[0-9]+}}: warning: global function 'CImplFunc1' of type '(Double) -> ()' does not match type '(Int32) -> Void' declared by the header; this will become an error after adopting '@implementation' | ||
| // NO-DAG: cdecl_implementation_features.swift:[[@LINE+3]]:{{[0-9]+}}: error: '_objcImplementation' attribute is only valid when experimental feature CImplementation is enabled | ||
| // YES-NOT: cdecl_implementation_features.swift:[[@LINE+2]]:{{[0-9]+}}: warning: warning-only '@_objcImplementation' spelling is deprecated; use '@implementation' instead |
There was a problem hiding this comment.
This CHECK line looks like it might be out of date
There was a problem hiding this comment.
Just noticed that myself. Good catch!
tshortli
approved these changes
Mar 28, 2024
• Simpler wording • Now emitted only if there are no other @objcImpl diagnostics (so @implementation would not emit any new errors)
beccadax
force-pushed
the
objcimpl-real-name
branch
from
0505c38 to
858b557
Compare
|
With swiftlang/swift-syntax#2570 @swift-ci please test |
|
I will shortly be pushing changes that make the matching swift-syntax PR unnecessary. |
Rather than adding custom parsing to SwiftSyntax, we can parse this as a custom attribute and convert it to a built-in one in ASTGen. Test that this works correctly (and fix a bug where it wasn’t).
|
@swift-ci please test |
|
🎉 |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a series of intertwined changes to
@_objcImplementation:@implementation, the public syntax I intend to propose@_objcImplementationwill continue to be supported for the time being; the old syntax will warn instead of error for checker diagnosticsObjCImplementationexperimental feature to gate access to@implementation extensions@_objcImplementationwill cause a deprecation warningCImplementationexperimental feature to gate access to@implementation @_cdecland@_objcImplementation @_cdeclTo aid in reviewing, I'm delaying some very mechanical follow-up work until another PR:
ObjCImplementationAttrtoImplementationAttr@_objcImplementationto using@implementationThis PR will need a matching swift-syntax PR.
Fixes rdar://110728033.