Skip to content

[6.0] Fix parsing issues related to suppressed conformances / noncopyable generics #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2024
Merged

[6.0] Fix parsing issues related to suppressed conformances / noncopyable generics #2585

merged 2 commits into from
Apr 2, 2024

Conversation

DougGregor
Copy link
Member

@DougGregor
Parse types with inverted constraints in expressions
6a67add 
Lookahead to determine when we are parsing a type within an expression
context was failing to consider inverted constraints. Make sure we look
past the `~` to an identifier.

(cherry picked from commit f6fad30)
@DougGregor
Correctly parse borrowing and consuming in function parameters
752c087 
(cherry picked from commit 06fa97d)
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor enabled auto-merge April 2, 2024 18:36
@DougGregor DougGregor mentioned this pull request Apr 2, 2024
Merged
@DougGregor DougGregor merged commit 7a8c1ef into swiftlang:release/6.0 Apr 2, 2024
@DougGregor DougGregor deleted the parse-suppressed-constraints-and-ownership-params-6.0 branch April 2, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougGregor