[6.0] Fix parsing issues related to suppressed conformances / noncopyable generics #72775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement parser and type-expression folding semantics for invertible protocols, so that one can write (e.g.) `[any ~Copyable]` as a type within expression context. Fixes rdar://125201146. (cherry picked from commit 7eb964c)
…them Ensure that we're properly parsing suppressed-conformance constraints in expression contents and in metatypes. This allows types like `any ~Copyable` in expression context as well as types like `any ~Copyable.Type`. While we're here, ensure that existentials that involve suppressed-conformance constraints are spelled with `any`. Fixes rdar://123728228. (cherry picked from commit 533a744)
(cherry picked from commit caf78cd)
|
@swift-ci please test |
hborla
approved these changes
Apr 3, 2024
DougGregor
deleted the
parse-suppressed-constraints-and-ownership-params-6.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~Copyable), including missing parsing of ownership modifiers on parameters (borrowingandconsuming) and failure to parse such types within expression context (e.g.,[~Copyable]()). Also validate (semantically) that existentials involving suppressed conformances requireany.borrowingandconsumingin function parameters swift-syntax#2580