[6.0] Allow borrowing without underscore in pattern matches.
#2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test with following pull request: @swift-ci Please test |
1 similar comment
|
Please test with following pull request: @swift-ci Please test |
rdar://126305009
jckarter
force-pushed
the
borrowing-switch-no-underscore-6.0
branch
from
27d551f to
b0a84b6
Compare
|
Please test with following pull request: @swift-ci Please test |
ahoppen
reviewed
Apr 12, 2024
Comment on lines
-733
to
+730
| substructure: ExprSyntax(DeclReferenceExprSyntax(baseName: .identifier("_borrowing"))), | ||
| substructure: ExprSyntax(DeclReferenceExprSyntax(baseName: .identifier("borrowing"))), |
There was a problem hiding this comment.
Would it make sense to continue having tests for _borrowing?
There was a problem hiding this comment.
My hope is that the warning I added in swiftlang/swift#72996 will get the early adopters over the new syntax so I can clean up the temporary syntax in a follow up commit.
ahoppen
approved these changes
Apr 12, 2024
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Allows
borrowing xin addition to_borrowing xin pattern matches when theBorrowingSwitchexperimental feature flag is enabled.Scope: New feature enablement
Issue: rdar://126305009
Original PR: #2599
Risk: Low. The new syntax is enabled in a way that should keep the keyword usage contextual so that existing code does not break.
Testing: Swift CI, compatibility test suite
Reviewer: @ahoppen