Skip to content

[6.0] Accept borrowing in pattern matches without underscore. #72996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Apr 12, 2024

Explanation: Allows borrowing x in addition to _borrowing x in pattern matches when the BorrowingSwitch experimental feature flag is enabled.
Scope: New feature enablement
Issue: rdar://126305009
Original PR: #72995
Risk: Low. The new syntax is enabled in a way that should keep the keyword usage contextual so that existing code does not break.
Testing: Swift CI, compatibility test suite
Reviewer: @atrick

@jckarter jckarter requested a review from a team as a code owner April 12, 2024 01:34
@jckarter jckarter requested a review from kavon April 12, 2024 01:34
@jckarter
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift-syntax#2600

@swift-ci Please test

@jckarter
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift-syntax#2600

@swift-ci Please test Linux

@jckarter jckarter changed the title Accept borrowing in pattern matches without underscore. [6.0] Accept borrowing in pattern matches without underscore. Apr 12, 2024
@jckarter jckarter merged commit b0ac3e0 into swiftlang:release/6.0 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants