[SwiftParser] Handle extraneous case keyword after comma in switch case. #2665
Conversation
|
@swift-ci Please test |
Head branch was pushed to by a user without write access
|
Oops! That test didn't fail for me locally, but I see the problem. |
There was a problem hiding this comment.
Thanks for the quick fix. Could you also squash your commits? We generally prefer that (https://github.com/apple/swift-syntax/blob/main/CONTRIBUTING.md#authoring-commits)
| arena: self.arena | ||
| ) | ||
| } else { | ||
| unexpectedPrePatternCase = nil |
There was a problem hiding this comment.
Can you change indentation to 2 spaces by running swift-format (https://github.com/apple/swift-syntax/blob/main/CONTRIBUTING.md#formatting)?
There was a problem hiding this comment.
Done! Sorry about the sloppiness.
|
@swift-ci Please test |
|
By the way, the test didn’t fail locally for you because CI runs test case mutation which isn’t enabled by default. https://github.com/apple/swift-syntax/blob/main/CONTRIBUTING.md#test-case-mutation has a little more documentation about it. |
|
@swift-ci Please test |
For errors of the form
case .a, case .b:instead of the expectedcase .a, .b:, produce just a single initial unexpected token in the secondSwitchCaseItemSyntaxinstead of a bad pattern and then a second separate full case.See swiftlang/swift#74071, which is essentially the same change made to the old parser.