[Parse] Add diagnostic for extraneous case keyword when multiple patterns. #74071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a diagnostic for code that tries to use a second
case
keyword when writing a case statement with multiple patterns. E.g.case .a, case .b:
instead ofcase .a, .b:
. I've seen several people do this while pair programming and a recent question in the iOS-dev Slack on how to do this made me realize the current diagnostics for this (IMHO) common error are pretty terrible:(This is because the second
case
causes pattern parsing to fail and the recovery inserts a match-anything pattern - thus the confusing warning.)With this change, you get a single error, and a fix-it to remove the offending token: