Enable the sendingArgsAndResults experimental feature
#2835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SE-0430 was accepted for Swift 6.0 but the experimental feature was not enabled with the proposal’s acceptance.
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Sep 5, 2024
- **Explanation**: [SE-0430](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0430-transferring-parameters-and-results.md) was accepted for Swift 6.0 but the corresponding experimental feature `sendingArgsAndResults` in swift-syntax was not enabled with the proposal’s acceptance. Because of this, SwiftParser cannot parse eg. `func whatever(_ foo: sending Foo)` - **Scope**: Parsing of `sending` parameters in SwiftParser - **Risk**: Fairly low, this is enabling a feature flag. - **Testing**: Ran test suite - **Issue**: swiftlang#2836 / rdar://135336930 - **Original PR**: swiftlang#2835 - **Reviewer**: @bnbarham @rintaro @hamishknight
This was referenced Sep 5, 2024
bnbarham
approved these changes
Sep 5, 2024
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Sep 5, 2024
- **Explanation**: [SE-0430](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0430-transferring-parameters-and-results.md) was accepted for Swift 6.0 but the corresponding experimental feature `sendingArgsAndResults` in swift-syntax was not enabled with the proposal’s acceptance. Because of this, SwiftParser cannot parse eg. `func whatever(_ foo: sending Foo)` - **Scope**: Parsing of `sending` parameters in SwiftParser - **Risk**: Fairly low, this is enabling a feature flag. - **Testing**: Ran test suite - **Issue**: swiftlang#2836 / rdar://135336930 - **Original PR**: swiftlang#2835 - **Reviewer**: @bnbarham @rintaro @hamishknight
rintaro
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0430 was accepted for Swift 6.0 but the experimental feature was not enabled with the proposal’s acceptance.