[6.0.1] Enable the sendingArgsAndResults experimental feature
#2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
This was referenced Sep 5, 2024
- **Explanation**: [SE-0430](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0430-transferring-parameters-and-results.md) was accepted for Swift 6.0 but the corresponding experimental feature `sendingArgsAndResults` in swift-syntax was not enabled with the proposal’s acceptance. Because of this, SwiftParser cannot parse eg. `func whatever(_ foo: sending Foo)` - **Scope**: Parsing of `sending` parameters in SwiftParser - **Risk**: Fairly low, this is enabling a feature flag. - **Testing**: Ran test suite - **Issue**: swiftlang#2836 / rdar://135336930 - **Original PR**: swiftlang#2835 - **Reviewer**: @bnbarham @rintaro @hamishknight
ahoppen
force-pushed
the
6.0/enable-sending-arg
branch
from
2f0f08a to
7aa2516
Compare
bnbarham
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendingArgsAndResultsin swift-syntax was not enabled with the proposal’s acceptance. Because of this, SwiftParser cannot parse eg.func whatever(_ foo: sending Foo)sendingparameters in SwiftParsersendingkeyword #2836 / rdar://135336930sendingArgsAndResultsexperimental feature #2835